-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Security} az security api-collection apim onboard/offboard
: Fix the documentation
#30716
Open
aditdalvi
wants to merge
2
commits into
Azure:dev
Choose a base branch
from
aditdalvi:patch-1
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix example
️✔️AzureCLI-FullTest
|
Hi @aditdalvi, |
️✔️AzureCLI-BreakingChangeTest
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
@yonzhan Can you please take a look at this PR? This is coming from a customer escalation, so I would like it to be merged asap |
/azp run |
kairu-ms
approved these changes
Feb 12, 2025
Azure Pipelines successfully started running 3 pipeline(s). |
az security api-collection apim onboard/offboard
: Fix the documentation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az security api-collection apim onboard
az security api-collection apim offboard
Description
The purpose of this PR is to fix the documentation for two az security api-collection apim commands -- onboard and offboard. Specifically, the example for onboard was incorrect and the example for offboard was missing. We were made aware of this by a customer through https://portal.microsofticm.com/imp/v5/incidents/details/586915494/summary.
Testing Guide
N/A
History Notes
{Security}
az security api-collection apim onboard/offboard
: Fix the documentationThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.